[PATCH] D56351: Replace function attributes "no-frame-pointer-elim" and "no-frame-pointer-elim-non-leaf" with "frame-pointer"

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg accepted this revision.
thegameg added a reviewer: thegameg.
thegameg added a comment.

This LGTM with one small comment change, thanks! You might want to add to the commit message the fact that the target now overrides the function attribute, which could change the behavior for (out of tree) targets.



================
Comment at: include/llvm/CodeGen/TargetFrameLowering.h:211
+  /// Return true if the target wants to keep frame pointer instead of
+  /// looking at function attribute "frame-pointer"
+  virtual bool keepFramePointer(const MachineFunction &MF) const {
----------------
I would say something like:

```
Return true if the target wants to keep the frame pointer regardless of the function attribute "frame-pointer".
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56351/new/

https://reviews.llvm.org/D56351