[PATCH] D53667: [llvm-objcopy] Handle -O <format> flag.

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht marked 2 inline comments as done.
rupprecht added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/cross-arch-sections-symbols.test:26
+      Section:  .text
+      Value:    0x1234
+    - Name:     bar
----------------
jhenderson wrote:
> rupprecht wrote:
> > jhenderson wrote:
> > > These values should probably be inside the sections, once they have non-zero size.
> > Done; is this what you meant?
> Almost. The symbol value of foo points to somewhere that isn't inside .text (i.e. it has value 0x1234, but the section size is only 32, so it's a long way past the end). It's not technically invalid ELF format, but it is a bit weird. If you don't want to update again, that's fine, but changing the value to, say, 16, would be my preference.
Oh, I see what you mean now -- thanks, changed to 16.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53667/new/

https://reviews.llvm.org/D53667