[PATCH] D56388: [ELF] Remove checking for spurious '@' at the end of dynamic symbol names

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: ruiu, grimar, rupprecht, mstorsjo, Higuoxing, jakehehrlich.
Herald added subscribers: dexonsmith, steven_wu, atanasyan, jrtc27, kbarton, arichardson, nemanjai, emaste.
Herald added a reviewer: espindola.

llvm-readobj currently has a bug (see PR40097) where it prints '@' at the end of unversioned symbols. I have a fix for this bug ready (see D56319 <https://reviews.llvm.org/D56319>), but the fix breaks a number of LLD tests which explicitly check the spurious '@'. This change removes this checking.

I don't have my system setup to do cross-repo commits, so this change is needed before D56319 <https://reviews.llvm.org/D56319> can land.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D56388

Files:
  test/ELF/as-needed-weak.s
  test/ELF/bsymbolic-undef.s
  test/ELF/common-gc2.s
  test/ELF/dont-export-hidden.s
  test/ELF/dynamic-list-preempt.s
  test/ELF/dynamic-list-wildcard.s
  test/ELF/dynamic-list.s
  test/ELF/dynsym-no-rosegment.s
  test/ELF/dynsym-pie.s
  test/ELF/empty-ver.s
  test/ELF/empty-ver2.s
  test/ELF/gc-sections-linker-defined-symbol.s
  test/ELF/gnu-hash-table-copy.s
  test/ELF/gnu-hash-table.s
  test/ELF/gnu-unique.s
  test/ELF/linkerscript/provide-shared2.s
  test/ELF/linkerscript/version-script.s
  test/ELF/local-dynamic.s
  test/ELF/local-ver-preemptible.s
  test/ELF/lto/dynamic-list.ll
  test/ELF/lto/shlib-undefined.ll
  test/ELF/lto/undefined-puts.ll
  test/ELF/lto/version-script.ll
  test/ELF/mips-dynamic.s
  test/ELF/mips-dynsym-sort.s
  test/ELF/mips-got-and-copy.s
  test/ELF/mips-got-extsym.s
  test/ELF/mips-got16.s
  test/ELF/mips-micro-plt.s
  test/ELF/mips-sto-plt.s
  test/ELF/progname.s
  test/ELF/protected-shared.s
  test/ELF/relative-dynamic-reloc-ppc64.s
  test/ELF/relative-dynamic-reloc.s
  test/ELF/retain-symbols-file.s
  test/ELF/shared.s
  test/ELF/undef-version-script.s
  test/ELF/verdef-defaultver.s
  test/ELF/verdef.s
  test/ELF/verneed.s
  test/ELF/version-script-complex-wildcards.s
  test/ELF/version-script-extern-undefined.s
  test/ELF/version-script-extern-wildcards.s
  test/ELF/version-script-extern.s
  test/ELF/version-script-extern2.s
  test/ELF/version-script-hide-so-symbol.s
  test/ELF/version-script-locals-extern.s
  test/ELF/version-script-symver2.s
  test/ELF/version-script-weak.s
  test/ELF/version-script.s
  test/ELF/version-wildcard.test
  test/ELF/visibility.s
  test/ELF/weak-undef-export.s
  test/ELF/weak-undef.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56388.180490.patch
Type: text/x-patch
Size: 41764 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190107/a0854c91/attachment-0001.bin>