[PATCH] D56331: AMDGPU: test for uniformity of branch instruction, not its condition

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 7 06:13:28 PST 2019


arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/divergent-branch-uniform-condition.ll:8
+
+; FUNC-LABEL: {{^}}main:
+; CHECK: v_sqrt_f32_e32
----------------
Wrong check prefix


================
Comment at: test/CodeGen/AMDGPU/divergent-branch-uniform-condition.ll:9-11
+; CHECK: v_sqrt_f32_e32
+; CHECK-NEXT: BB0_{{[0-9]+}}:
+; CHECK-NEXT: s_or_b64 exec, exec
----------------
The checks are too thin. Maybe for this you should just use update_llc_test_checks?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56331/new/

https://reviews.llvm.org/D56331





More information about the llvm-commits mailing list