[PATCH] D56289: [AMDGPU] Fixed cvt_f32_ubyte combine

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 12:27:43 PST 2019


rampitec marked an inline comment as done.
rampitec added a comment.

In D56289#1345663 <https://reviews.llvm.org/D56289#1345663>, @arsenm wrote:

> Probably should try fixing ShrinkDemandedConstant first


I have checked existing uses of ShrinkDemandedConstant, it doe snot look these uses really care about multiple use situation. Therefor I have moved single use check there.

Concerning SimplifyDemandedBits is handles multiple uses gracefully, which is documented:

> Helper for SimplifyDemandedBits that can simplify an operation with multiple uses.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56289/new/

https://reviews.llvm.org/D56289





More information about the llvm-commits mailing list