[PATCH] D56355: [InstCombine] Simplify cttz/ctlz + icmp ugt/ult into mask check

[Nikita Popov via Phabricator via llvm-commits]

nikic marked 3 inline comments as done.
nikic added a comment.

In D56355#1347365 <https://reviews.llvm.org/D56355#1347365>, @lebedev.ri wrote:

> Hm, why does this modify the existing instruction, and manually adds it to worklist,
>  instead of simply creating a new instruction? This is rather unusual for instcombine i think.


I assumed that this was to avoid creating a new instruction when we can reuse an existing one. If this is just an anachronism, I can switch the existing code to create new nodes in a separate NFC commit and then adjust it here as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56355/new/

https://reviews.llvm.org/D56355