[PATCH] D53895: [LoopUnroll] add parsing for unroll parameters in -passes pipeline

[Philip Pfaffe via Phabricator via llvm-commits]

philip.pfaffe added a comment.

Cool! Down to bikeshed comments :)



================
Comment at: lib/Passes/PassRegistry.def:234
 
+#ifndef FUNCTION_PASS_PARAMETRIZED
+#define FUNCTION_PASS_PARAMETRIZED(NAME, CREATE_PASS, PARSER)
----------------
I'd prefer PARAMETERIZED_FUNCTION_PASS or FUNCTION_PASS_WITH_PARAMS or the like.


================
Comment at: lib/Passes/PassRegistry.def:237
+#endif
+FUNCTION_PASS_PARAMETRIZED("unroll",                                                    \
+			   [](LoopUnrollOptions Opts) { return LoopUnrollPass(Opts); }, \
----------------
No \ required here.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53895/new/

https://reviews.llvm.org/D53895