[PATCH] D56330: [gn build] Add build files for unittests that load shared libraries

[Nico Weber via Phabricator via llvm-commits]

thakis marked an inline comment as done.
thakis added inline comments.


================
Comment at: llvm/utils/gn/secondary/llvm/unittests/Support/DynamicLibrary/BUILD.gn:8
+  # GN doesn't like if a template doesn't use invoker at all, even
+  # with not_needed(invoker), so pass in a dummy always-true bool.
+  assert(invoker.dummy)
----------------
thakis wrote:
> phosek wrote:
> > Have you tried `not_needed(invoker, "*")`? We use that in our build.
> That works, thanks! (Just `not_needed(invoker)` makes gn fail, but without any error message.)
(filed https://bugs.chromium.org/p/gn/issues/detail?id=38 for the gn issue)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56330/new/

https://reviews.llvm.org/D56330