[PATCH] D34919: [Inliner] Optimize shouldBeDeferred

Easwaran Raman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 16:31:13 PST 2019


eraman added a comment.



In D34919#1346759 <https://reviews.llvm.org/D34919#1346759>, @eraman wrote:

> Reviving this old patch as Wei recently noticed a case where a large function with many callees and many callers spent significant amount of time in shouldBeDeferred. This was triggered by change in profile causing many callees to be inlined into this large function.


The instance Wei observed didn't have multiple callers. I mis-understood the case and Wei thought this patch fixed the issue, but it actually didn't. Still, I think this is a useful fix.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D34919/new/

https://reviews.llvm.org/D34919





More information about the llvm-commits mailing list