[PATCH] D56330: [gn build] Add build files for unittests that load shared libraries
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 4 16:25:18 PST 2019
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/utils/gn/secondary/llvm/unittests/Support/DynamicLibrary/BUILD.gn:8
+ # GN doesn't like if a template doesn't use invoker at all, even
+ # with not_needed(invoker), so pass in a dummy always-true bool.
+ assert(invoker.dummy)
----------------
Have you tried `not_needed(invoker, "*")`? We use that in our build.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56330/new/
https://reviews.llvm.org/D56330
More information about the llvm-commits
mailing list