[PATCH] D56294: [ObjectYAML] [COFF] Support multiple symbols with the same name

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap accepted this revision.
alexshap added a comment.
This revision is now accepted and ready to land.

LGTM with one minor nit



================
Comment at: tools/obj2yaml/coff2yaml.cpp:151
+    Obj.getSymbolName(Symbol, Name);
+    auto It = SymbolUnique.find(Name);
+    if (It == SymbolUnique.end())
----------------
side note: double lookup (1st - find, second - operator []) can be avoided here if we switch to using the method "insert" instead (it returns the corresponding iterator).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56294/new/

https://reviews.llvm.org/D56294