[PATCH] D56337: [ADT] Remove attribute LLVM_ALWAYS_INLINE from several classes.

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 15:11:04 PST 2019


davide created this revision.
davide added reviewers: chandlerc, JDevlieghere, friss, aprantl.
Herald added a subscriber: dexonsmith.

The original motivation for this was trying to get faster turnaround
when running check-llvm at `-O0`. The impact on debuggability seems
to outweight the benefits, as it makes StringRef and other ADT
classes fairly undebuggable.

Add a section in the developer's documentation explaining that
optimized builds are needed for decent test performances instead.

Based on a discussion on llvm-dev, pending more general consensus.


https://reviews.llvm.org/D56337

Files:
  llvm/docs/TestingGuide.rst
  llvm/include/llvm/ADT/SmallVector.h
  llvm/include/llvm/ADT/StringRef.h
  llvm/include/llvm/ADT/StringSwitch.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56337.180331.patch
Type: text/x-patch
Size: 16098 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190104/59eb1e30/attachment.bin>


More information about the llvm-commits mailing list