[PATCH] D34919: [Inliner] Optimize shouldBeDeferred

[Easwaran Raman via Phabricator via llvm-commits]

eraman marked an inline comment as done.
eraman added a comment.

In D34919#1346838 <https://reviews.llvm.org/D34919#1346838>, @chandlerc wrote:

> Nice, LGTM!
>
> Does it make sense to add a (very early) assert that the thresholds are non-negative? I agree with you that it shouldn't be happening and it seems like a good invariant to enforce. Can of course be a follow-up patch.


I don't know if we make implicit assumptions about threshold being positive, but I agree this seems a reasonable invariant to enforce. I turned on an assert and found that a test case that passes  --inline-threshold=-2 breaks. I will add the assert in a follow-up patch along with the fix to the test.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D34919/new/

https://reviews.llvm.org/D34919