[PATCH] D55881: [llvm-objcopy] [COFF] Add support for removing symbols

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 13:45:08 PST 2019


mstorsjo updated this revision to Diff 180315.
mstorsjo marked 4 inline comments as done.
mstorsjo added a comment.

Changed a few cases of std::vector to ArrayRef as suggested, moved the getMutableSymbols method next to getSymbols as suggested, added a comment about the verbose tests, and changed the test input to yaml (depending on D56294 <https://reviews.llvm.org/D56294>).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55881/new/

https://reviews.llvm.org/D55881

Files:
  test/tools/llvm-objcopy/COFF/Inputs/remove-symbols.yaml
  test/tools/llvm-objcopy/COFF/remove-symbol1.test
  test/tools/llvm-objcopy/COFF/remove-symbol2.test
  tools/llvm-objcopy/CMakeLists.txt
  tools/llvm-objcopy/COFF/COFFObjcopy.cpp
  tools/llvm-objcopy/COFF/Object.cpp
  tools/llvm-objcopy/COFF/Object.h
  tools/llvm-objcopy/COFF/Reader.cpp
  tools/llvm-objcopy/COFF/Reader.h
  tools/llvm-objcopy/COFF/Writer.cpp
  tools/llvm-objcopy/COFF/Writer.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55881.180315.patch
Type: text/x-patch
Size: 22091 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190104/ff4c2117/attachment.bin>


More information about the llvm-commits mailing list