[PATCH] D56219: [gn build] Add build files for LLVM unittests with a custom main() function

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 09:02:18 PST 2019


phosek added inline comments.


================
Comment at: llvm/utils/gn/secondary/llvm/utils/unittest/unittest.gni:53
+# //llvm/utils/unittest/UnitTestMain.
+template("unittest_with_custom_main") {
+  executable(target_name) {
----------------
I'm not a big fan of the name, have you considered naming it e.g. `gtest`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56219/new/

https://reviews.llvm.org/D56219





More information about the llvm-commits mailing list