[PATCH] D56265: [DebugInfo] MCP: collect and update DBG_VALUEs encountered in local block
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jan 4 07:33:08 PST 2019
aprantl added inline comments.
================
Comment at: lib/CodeGen/MachineCopyPropagation.cpp:211
+ void ReadRegister(unsigned Reg, MachineInstr &Reader,
+ bool IsDebug = false);
void CopyPropagateBlock(MachineBasicBlock &MBB);
----------------
instead of an opaque optional parameter, we could also define
```
enum { DebugUse = false, RegularUse = true };
```
possibly with better names and explicitly pass it every time. Up to you.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56265/new/
https://reviews.llvm.org/D56265
More information about the llvm-commits
mailing list