[PATCH] D56151: [DebugInfo] PR40010: Avoid register coalesing altering DBG_VALUE valuations

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 07:30:58 PST 2019


aprantl added inline comments.


================
Comment at: lib/CodeGen/RegisterCoalescer.cpp:248
+    /// When merging SrcReg and DstReg together, and the operand of the
+    /// specified DBG_VALUE refers to one of them, would the valuation of the
+    /// DBG_VALUE change? This can happen when the DBG_VALUEs operand is dead
----------------
`valuation` is not a term we typically use in this context? Perhaps `should the operands of the DBG_VALUE be updated`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56151/new/

https://reviews.llvm.org/D56151





More information about the llvm-commits mailing list