[PATCH] D55503: Change llvm call once check for building Swift for PowerPC(ppc64le)

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 06:22:57 PST 2019


nemanjai added a comment.

Sarvesh, I've tried this on a PPC64LE machine with one version of GLIBC and found no problems. However, I am reluctant to just go ahead with a change without testing with a few other versions of GLIBC.

Would you be able to:

1. Post a new revision for this so we're not communicating via a closed review
2. Disentangle the conditions into perhaps multiple `#if`/`#`elif` blocks as this is very difficult to parse

Then we can do another round of review and testing before we finalize this.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55503/new/

https://reviews.llvm.org/D55503





More information about the llvm-commits mailing list