[PATCH] D56195: [gn build] Add check-llvm target and make it work

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 05:57:17 PST 2019


thakis added a comment.

In D56195#1346133 <https://reviews.llvm.org/D56195#1346133>, @serge-sans-paille wrote:

> LGTM, but *only* with respect to the Python 2/3 compatibility of the modification, which is just a drop in the ocean of this patch.


Thanks! I landed that part in r350394, and moved other dependencies into their own issues D56316 <https://reviews.llvm.org/D56316>, D56317 <https://reviews.llvm.org/D56317>. Hopefully that makes this patch here a bit easier to handle.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56195/new/

https://reviews.llvm.org/D56195





More information about the llvm-commits mailing list