[PATCH] D56295: [TSan] Use switches when dealing with enums

[Dan Liew via Phabricator via llvm-commits]

delcypher added inline comments.


================
Comment at: lib/tsan/rtl/tsan_debugging.cc:41
+  }
 }
 
----------------
@yln I'd feel slightly happier by having `UNREACHABLE("Unhandled case");` after the switch block (i.e. don't add a default case) so that if we do fall through (because someone missed a compiler warning, or perhaps they have warnings turned off) we stop execution rather than having undefined behaviour (reach end of function but no return statement).

This applies to all the switch blocks you've added.

I won't insist on this but if you think this a reasonable change that doesn't clutter things too much then I think you should do it.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56295/new/

https://reviews.llvm.org/D56295