[PATCH] D56312: [llvm-nm] Add --portability as alias for --format=posix

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 4 03:57:15 PST 2019


jhenderson created this revision.
jhenderson added reviewers: rupprecht, MaskRay, mstorsjo, phosek.

--portability is a GNU nm alias for --format=posix. To ensure command-line compatibility, we need to add it to llvm-nm.


Repository:
  rL LLVM

https://reviews.llvm.org/D56312

Files:
  test/tools/llvm-nm/X86/posix-aliases.test
  tools/llvm-nm/llvm-nm.cpp


Index: tools/llvm-nm/llvm-nm.cpp
===================================================================
--- tools/llvm-nm/llvm-nm.cpp
+++ tools/llvm-nm/llvm-nm.cpp
@@ -91,6 +91,8 @@
                         cl::Grouping);
 cl::opt<bool> POSIXFormat("P", cl::desc("Alias for --format=posix"),
                           cl::Grouping);
+cl::alias Portability("portability", cl::desc("Alias for --format=posix"),
+                      cl::aliasopt(POSIXFormat), cl::NotHidden);
 cl::opt<bool> DarwinFormat("m", cl::desc("Alias for --format=darwin"),
                            cl::Grouping);
 
Index: test/tools/llvm-nm/X86/posix-aliases.test
===================================================================
--- test/tools/llvm-nm/X86/posix-aliases.test
+++ test/tools/llvm-nm/X86/posix-aliases.test
@@ -0,0 +1,5 @@
+# RUN: llvm-nm -P %p/Inputs/hello.obj.elf-x86_64 > %t1
+# RUN: llvm-nm -format=posix %p/Inputs/hello.obj.elf-x86_64 > %t2
+# RUN: llvm-nm -portability %p/Inputs/hello.obj.elf-x86_64 > %t3
+# RUN: diff %t1 %t2
+# RUN: diff %t1 %t3


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56312.180218.patch
Type: text/x-patch
Size: 1046 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190104/7e8e151b/attachment.bin>


More information about the llvm-commits mailing list