[PATCH] D56284: [UnrollRuntime] Fix domTree failure in multiexit unrolling

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 3 15:14:06 PST 2019


anna added a comment.

In D56284#1345766 <https://reviews.llvm.org/D56284#1345766>, @kuhar wrote:

> @anna Can this be rewritten to use the DomTreeUpdater utility?


@kuhar, I have not looked at the DTU uttility yet, but I'd think it can be rewritten (unless there are some limitations for the DomTreeUpdater utility). However, that would be a large enough change and I think it's better to do it as a separate change at a later point rather than as part of fixing this bug. Also, there are enough DT updates through out this code that it will take a while to get through the whole process of porting over for runtime unrolling.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56284/new/

https://reviews.llvm.org/D56284





More information about the llvm-commits mailing list