[PATCH] D56227: [WebAssembly] Fixed disassembler not knowing about new brlist operand
Wouter van Oortmerssen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 3 14:08:56 PST 2019
aardappel added inline comments.
================
Comment at: utils/TableGen/WebAssemblyDisassemblerEmitter.cpp:95
for (auto &Op : CGI.Operands.OperandList) {
+ assert(Op.OperandType != "MCOI::OPERAND_UNKNOWN");
CurOperandList.push_back(Op.OperandType);
----------------
aheejin wrote:
> How is this related?
The original problem was triggered by the disassembler asserting on `OPERAND_UNKNOWN` when trying to disassemble `br_table`. There shouldn't really ever be any `OPERAND_UNKNOWN` in the operand table. If this assert had been here before, I would have caught this problem at build time rather than at runtime.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56227/new/
https://reviews.llvm.org/D56227
More information about the llvm-commits
mailing list