[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

Thu Jan 3 13:26:15 PST 2019

krytarowski added a comment.

I think that ifdefining the linker options with `__NetBSD__` is no-go.

In D56215#1345563 <https://reviews.llvm.org/D56215#1345563>, @mgorny wrote:

> We've discussed this a bit and given other changes we need to do, and I see pretty much three options here:
>
> 1. We hardcode stuff under `defined(__NetBSD__)` which kinda solves the problem, except lld won't be very cross-friendly.

I think that ifdefining the linker options with `__NetBSD__` is no-go. We expect to get lld to link NetBSD programs from any host, or from NetBSD to any other.

> 2. We try to do conditionals based on triple but this works only when we customize the install to include it in executable name. We probably would still need to default based on `defined(__NetBSD__)` when triple isn't available via process name.

I think it won't work for us.

> 3. We create `*nbsd*` emulations for all arches (e.g. amd64/x86 don't have such emulations right now), and use that to switch logic. This would be closer to what FreeBSD does, I think. However, if we do this, then I suppose we should also add similar aliases to GNU ld.

Probably too gross hack just for the gain redesigned model of a linker functional.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56215/new/

https://reviews.llvm.org/D56215