[PATCH] D56223: [WebAssembly] Made InstPrinter more robust

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 3 12:26:14 PST 2019


aardappel added inline comments.


================
Comment at: lib/Target/WebAssembly/InstPrinter/WebAssemblyInstPrinter.cpp:304
+  default:
+    return "invalid_type";
   }
----------------
aheejin wrote:
> So does this print "invalid_type" even when we have an invalid instruction within itself?
I'm not sure what you mean. It currently prints this only when an instruction explicitly tries to print an operand that is a block_type or other signature, and it happens to be an unknown value.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56223/new/

https://reviews.llvm.org/D56223





More information about the llvm-commits mailing list