[PATCH] D56080: update the pr_datasz of .note.gnu.property section

Vyacheslav Zakharin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 3 11:18:04 PST 2019


vzakhari added a comment.

I think I got it, finally, after talking with HJ.  As defined in https://github.com/hjl-tools/x86-psABI/blob/hjl/master/dl.tex, the pr_data field consists of 4-byte integers for GNU_PROPERTY_X86_FEATURE_1_AND program property type (pr_type).  At the same time, the program property array must be a multiple of 8 bytes on x86-64 (as stated in https://github.com/hjl-tools/linux-abi/blob/hjl/master/object-files.tex), thus, the alignment is computed properly.

It looks good to me, but please align the comment on line 577 with the comment on the previous line.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56080/new/

https://reviews.llvm.org/D56080





More information about the llvm-commits mailing list