[PATCH] D54337: [ASan] Make AddressSanitizer a ModulePass

[Philip Pfaffe via Phabricator via llvm-commits]

philip.pfaffe added a comment.

> I haven't gotten back to this yet, but will do so after looking into what may be required for also porting SafeStack and ShadowCallStack to new PM.

If I recall correctly, it was pointed out on the SafeStack thread that, since SafeStack is part of CodeGen, porting it is not possible right now.

> You're right in that Asan doesn't need to keep track of changes between IR units. I haven't started this yet, but the main thing I was concerned about was that, for some reason, function passes in the new PM couldn't depend on module level analyses and only function level analyses, but I think this is false since `TargetLibraryAnalysis` is an example of an analysis that was ported but is required by many function passes.

`TargetLibraryAnalysis` is in fact a function analysis. Function analyses cannot request Module analyses to be ran, that is correct. They can, however, use analysis results that are already available.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54337/new/

https://reviews.llvm.org/D54337