[PATCH] D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: test/Transforms/AggressiveInstCombine/mul128.ll:1
+; RUN: opt < %s -aggressive-instcombine -S | FileCheck %s
+
----------------
chfast wrote:
> lebedev.ri wrote:
> > chfast wrote:
> > > lebedev.ri wrote:
> > > > Please use `llvm/utils/update_test_checks.py`.
> > > > And move the initial test case into another review, so this diff shows the *change* in the test output.
> > > Tests added as https://reviews.llvm.org/D56277.
> > (Yep, now this diff just needs to be based ontop of that diff, so the tests show difference)
> Can this be done in Phabricator?
Phabricator only displays the diff you upload.
If you used git for this, simply keep these two diffs as two consecutive commits,
and upload each one of them separately to their respective reviews.
If svn, no idea.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56214/new/

https://reviews.llvm.org/D56214