[PATCH] D56211: [llvm-objcopy][ELF] Implement a mutable section visitor that updates size-related fields (Size, EntrySize, Align) before layout.

Thu Jan 3 09:56:23 PST 2019

rupprecht marked an inline comment as done.
rupprecht added inline comments.

================
Comment at: llvm/trunk/tools/llvm-objcopy/ELF/Object.cpp:89
+  Sec.Size = Sec.Symbols.size() * Sec.EntrySize;
+  // Align to the larget field in Elf_Sym.
+  Sec.Align = sizeof(Elf_Sym::st_size);
----------------
jhenderson wrote:
> Nit: larget -> largest
d'oh.... haven't had coffee yet :(

Fixed in r350337

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56211/new/

https://reviews.llvm.org/D56211