[PATCH] D56046: Output ELF files after ThinLTO is run.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 3 09:32:13 PST 2019
ruiu added inline comments.
================
Comment at: ELF/LTO.cpp:225
+
+class raw_multi_ostream : public llvm::raw_svector_ostream {
+ std::unique_ptr<raw_pwrite_stream> OS;
----------------
I don't think we need this kind of sophisticated abstraction. I believe you can just write Buf contents to files after data is written to Buf. Please take a look at https://gist.github.com/rui314/836cc9dab97922271b63dba3d1d5a3f5. All tests still pass with that patch.
So, if my understanding is correct, the only difference between save-temps and obj-path is the basename of the created temporary files. Is this your expected behavior?
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56046/new/
https://reviews.llvm.org/D56046
More information about the llvm-commits
mailing list