[PATCH] D56207: Update allocator unit tests to test the `RemoteAddressSpaceView` template instantiation.

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 3 07:11:41 PST 2019


delcypher added a comment.

In D56207#1344528 <https://reviews.llvm.org/D56207#1344528>, @vitalybuka wrote:

> In D56207#1343995 <https://reviews.llvm.org/D56207#1343995>, @delcypher wrote:
>
> > In D56207#1343971 <https://reviews.llvm.org/D56207#1343971>, @kubamracek wrote:
> >
> > > This needs https://reviews.llvm.org/D56206 to land first, right?
> >
> >
> > Oops. Yes. I forgot to add the dependency in Phabricator. I've done it now.
>
>
> Tests suppose to pass after every patch.
>  Does D56206 <https://reviews.llvm.org/D56206> work without D56207 <https://reviews.llvm.org/D56207>
>  If not, you should merge them.


Yes, https://reviews.llvm.org/D56206 (the implementation, not this patch) works without https://reviews.llvm.org/D56207 (the tests for the implementation, this patch).

Or did you mean to ask that the other way round (i.e. Does https://reviews.llvm.org/D56207 work without https://reviews.llvm.org/D56206)?


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56207/new/

https://reviews.llvm.org/D56207





More information about the llvm-commits mailing list