[PATCH] D55887: Add support for background thread on NetBSD in ASan

Thu Jan 3 06:17:46 PST 2019

It's not possible to guess what's wrong.
 - Is the background thread started at all?
 - Is __local_asan_dyninit optimized away or not executed?
 - Is there a timing issue that test needs more time?

I don't have access to setup to reproduce it myself.

The patch fixed Android setup and enabled NetBSD.

I think that the problem is not caused by my change, but it's a side
effect of other bug/optimization. I can mark the test as XFAIL for your
setup or add ifdef for your Linux configuration to start the background
thread in the same way as before.

On 03.01.2019 11:05, Yvan Roux wrote:
> Hi Kamil,
> 
> This commit broke ARM Thumb bots by enabling Asan
> quarantine_size_mb.cc and hard_rss_limit_mb_test.cc test cases, recent
> logs are available here:
> 
> http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-full-sh/builds/1285/steps/ninja%20check%202/logs/FAIL%3A%20AddressSanitizer-armhf-linux%3A%3Aquarantine_size_mb.cc
> http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-full-sh/builds/1285/steps/ninja%20check%202/logs/FAIL%3A%20SanitizerCommon-asan-armhf-Linux%3A%3A%20hard_rss_limit_mb_test.cc
> 
> Thanks,
> Yvan
> 
> On Sat, 29 Dec 2018 at 01:35, Phabricator via Phabricator via
> llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>> This revision was automatically updated to reflect the committed changes.
>> Closed by commit rCRT350139: Add support for background thread on NetBSD in ASan (authored by kamil, committed by ).
>> Herald added a subscriber: srhines.
>>
>> Changed prior to commit:
>>   https://reviews.llvm.org/D55887?vs=178872&id=179669#toc
>>
>> Repository:
>>   rCRT Compiler Runtime
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D55887/new/
>>
>> https://reviews.llvm.org/D55887
>>
>> Files:
>>   lib/asan/asan_rtl.cc
>>   lib/sanitizer_common/sanitizer_common_libcdep.cc
>>   test/sanitizer_common/TestCases/Linux/hard_rss_limit_mb_test.cc
>>   test/sanitizer_common/TestCases/hard_rss_limit_mb_test.cc
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 850 bytes
Desc: OpenPGP digital signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190103/2d4dd778/attachment.sig>