[PATCH] D56251: python compat - assertraisesregex

[serge via Phabricator via llvm-commits]

serge-sans-paille marked an inline comment as done.
serge-sans-paille added inline comments.


================
Comment at: bindings/python/llvm/tests/base.py:21
+    if sys.version_info.major == 2:
+        assertRaisesRegex = TestBase.assertRaisesRegexp
+
----------------
michaelplatings wrote:
> I think this should be:
> assertRaisesRegex = unittest.TestCase.assertRaisesRegexp
Well It's actually the same as `TestBase` inherits from `unittest.TestCase`.

I prefer this form because it makes the renaming more explicit.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56251/new/

https://reviews.llvm.org/D56251