[PATCH] D56232: [lldb-server] Add remote platform capabilities for Windows
Pavel Labath via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 3 00:29:48 PST 2019
labath added reviewers: labath, jingham.
labath added a comment.
All of these functions seem identical to their PlatformPOSIX counterparts. Is that right? And I seem to remember already seeing a lot of code duplication between PlatformPOSIX and PlatformWindows.
It sounds to me like we should create a new common base class for PlatformWindows and PlatformPOSIX (`RemoteAwarePlatform`?), and put the common code there.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56232/new/
https://reviews.llvm.org/D56232
More information about the llvm-commits
mailing list