[PATCH] D56235: Teach ObjCARC optimizer about equivalent PHIs when eliminating autoreleaseRV/retainRV pairs

[Pete Cooper via Phabricator via llvm-commits]

pete marked 3 inline comments as done.
pete added a comment.

Thanks for the review.  Submitted as r350284.



================
Comment at: lib/Transforms/ObjCARC/ObjCARCOpts.cpp:625
+    if (GetBasicARCInstKind(&*I) == ARCInstKind::AutoreleaseRV) {
+      if (EquivalentArgs.count(GetArgRCIdentityRoot(&*I))) {
+        Changed = true;
----------------
ahatanak wrote:
> You can reduce indentation if you use `&&` instead of introducing an if statement here.
Good point.  I don't know why I changed that in the first place.  Much smaller patch now.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56235/new/

https://reviews.llvm.org/D56235