[PATCH] D56227: [WebAssembly] Fixed disassembler not knowing about new brlist operand
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 2 16:51:15 PST 2019
aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.
LGTM with nits
================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrControl.td:45
}
+} // OPERAND_BRLIST
+} // OperandNamespace = "WebAssembly"
----------------
Nit: double space
================
Comment at: utils/TableGen/WebAssemblyDisassemblerEmitter.cpp:95
for (auto &Op : CGI.Operands.OperandList) {
+ assert(Op.OperandType != "MCOI::OPERAND_UNKNOWN");
CurOperandList.push_back(Op.OperandType);
----------------
How is this related?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56227/new/
https://reviews.llvm.org/D56227
More information about the llvm-commits
mailing list