[PATCH] D56223: [WebAssembly] Made InstPrinter more robust

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

- Can we have a test case that shows the warning messages? Maybe adding a small separate file would be better than adding erroneous lines to basic-assembly.s
- In case you forgot, please clang-format



================
Comment at: lib/Target/WebAssembly/InstPrinter/WebAssemblyInstPrinter.cpp:304
+  default:
+    return "invalid_type";
   }
----------------
So does this print "invalid_type" even when we have an invalid instruction within itself?


================
Comment at: lib/Target/WebAssembly/InstPrinter/WebAssemblyInstPrinter.h:59
 
 const char *TypeToString(wasm::ValType Ty);
+const char *AnyTypeToString(unsigned Ty);
----------------
Function names should be camelCase


================
Comment at: lib/Target/WebAssembly/InstPrinter/WebAssemblyInstPrinter.h:60
 const char *TypeToString(wasm::ValType Ty);
+const char *AnyTypeToString(unsigned Ty);
 
----------------
Function names should be camelCase


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56223/new/

https://reviews.llvm.org/D56223