[PATCH] D56214: AggressiveInstCombine: Fold full mul i64 x i64 -> i128

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 2 15:47:05 PST 2019


craig.topper added inline comments.


================
Comment at: lib/Transforms/AggressiveInstCombine/AggressiveInstCombine.cpp:297
+
+  Value *x = nullptr;
+  Value *y = nullptr;
----------------
Don't you need to check the type is i64 somewhere? Or did I miss it?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56214/new/

https://reviews.llvm.org/D56214





More information about the llvm-commits mailing list