[PATCH] D55881: [llvm-objcopy] [COFF] Add support for removing symbols

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo updated this revision to Diff 179944.
mstorsjo added a comment.

Updating with most of the clear issues fixed, removed code for all other stripping modes than removing explicitly named symbols. Using `llvm-objdump -t` instead of `llvm-nm` for printing symbol lists, using `-NEXT` to avoid the risk of any missed symbols. Using `llvm::errc::invalid_argument` in one place, renamed `RawIdx` to `RawIndex`, added quoting around the symbol name for the erorr message, extended the error test to check for this and the file name.

Other issues that still are under discussion are not yet changed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55881/new/

https://reviews.llvm.org/D55881

Files:
  test/tools/llvm-objcopy/COFF/X86/lit.local.cfg
  test/tools/llvm-objcopy/COFF/X86/remove-symbol1.s
  test/tools/llvm-objcopy/COFF/X86/remove-symbol2.s
  tools/llvm-objcopy/CMakeLists.txt
  tools/llvm-objcopy/COFF/COFFObjcopy.cpp
  tools/llvm-objcopy/COFF/Object.cpp
  tools/llvm-objcopy/COFF/Object.h
  tools/llvm-objcopy/COFF/Reader.cpp
  tools/llvm-objcopy/COFF/Reader.h
  tools/llvm-objcopy/COFF/Writer.cpp
  tools/llvm-objcopy/COFF/Writer.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55881.179944.patch
Type: text/x-patch
Size: 13432 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190102/c233a465/attachment.bin>