[PATCH] D56223: [WebAssembly] Made InstPrinter more robust

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 2 13:53:34 PST 2019


aardappel created this revision.
aardappel added reviewers: dschuff, aheejin.
Herald added subscribers: llvm-commits, sunfish, jgravelle-google, sbc100.

Instead of asserting on certain kinds of malformed instructions, it
now still print, but instead adds an annotation indicating the
problem, and/or indicates invalid_type etc.

We're using the InstPrinter from many contexts that can't always
guarantee values are within range (e.g. the disassembler), where having
output is more valueable than asserting.


Repository:
  rL LLVM

https://reviews.llvm.org/D56223

Files:
  lib/Target/WebAssembly/InstPrinter/WebAssemblyInstPrinter.cpp
  lib/Target/WebAssembly/InstPrinter/WebAssemblyInstPrinter.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56223.179938.patch
Type: text/x-patch
Size: 6427 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190102/eff6fb57/attachment.bin>


More information about the llvm-commits mailing list