[PATCH] D56080: update the pr_datasz of .note.gnu.property section

Vyacheslav Zakharin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 2 13:15:59 PST 2019


vzakhari added a comment.

Please submit your patch with full context according to LLVM's documentation: https://www.llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

According to the documentation that you posted:
pr_datasz The size of the pr_data field. A 4-byte integer in the format of the target processor.
pr_data The program property descriptor which is aligned to 4 bytes in 32-bit objects and 8 bytes in 64-bit objects.

Line 576 emits WordSize bytes of data (which seems to be 8 bytes for x86-64), so why do you emit '4' for pr_datasz value?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56080/new/

https://reviews.llvm.org/D56080





More information about the llvm-commits mailing list