[PATCH] D56117: [ThinLTO] Scan all variants of vague symbol for reachability.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

The code change seems fine. Suggestion for test case simplification below.



================
Comment at: test/ThinLTO/X86/deadstrip.ll:85
+
+; Make sure we keep @goo alive because one variant of @linkonceodrfuncwithalias
+; is calling it.
----------------
Do we need goo to test the fix, or can't linkonceodrfuncwithalias be checked directly? The real issue seems to be that the prevailing copy of linkonceodrfuncwithalias in the second module is not kept without the fix. It should be kept and converted to weak_odr resolution, which you could check directly without having it call any functions.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56117/new/

https://reviews.llvm.org/D56117