[PATCH] D55944: [MemorySSA] Extend the clobber walker with the option to skip the starting access.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added a comment.

Ack, will hold off on checking this in until the follow-up use (walker) is finalized.



================
Comment at: lib/Analysis/MemorySSA.cpp:625
+      bool ReplacedStopWhere = false;
+      if (Query->SkipSelfAccess && Query->OriginalAccess &&
+          Node.Loc == Query->StartingLoc &&
----------------
george.burgess.iv wrote:
> Is it sensible to have SkipSelfAccess with Query->OriginalAccess == null?
AFAICT Query->OriginalAccess is never null, so no, not currently. Removing check.


================
Comment at: lib/Analysis/MemorySSA.cpp:628
+          Node.Last->getBlock() == Query->OriginalAccess->getBlock()) {
+        assert(isa<MemoryDef>(Query->OriginalAccess));
+        RealStopWhere = Query->OriginalAccess;
----------------
george.burgess.iv wrote:
> Can we move this assert where we plan to set `Query->SkipSelfAccess` to true?
> 
> That way, it'll fire 100% of the time if there's a bug, rather than only if we reach this piece of code
> 
> (I realize that'll be in the follow-up patch. Still. :) )
Ack, noted to include in follow-up patch.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55944/new/

https://reviews.llvm.org/D55944