[PATCH] D56114: [LTO] emit assembly listing from LTO stage

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Nit on patch description: use [gold] not [LTO] since this is about the gold plugin specifically, and not a change to the LTO API. Also, please add a gold test.



================
Comment at: tools/gold/gold-plugin.cpp:1078
+    if (Files.size() == 1)
+      CopyFile(Files.front().first.str(), output_name);
+    else
----------------
Rather than doing this copying, I think you could modify the invocation of getOutputFileName so that it sets Filename to output_name (or maybe output_name + ".s"?) in this case. I.e. see what it does when the output type is OT_SAVE_TEMPS. Then it should emit the assemble to the desired file directly.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56114/new/

https://reviews.llvm.org/D56114