[PATCH] D55886: [llvm-objcopy] - Do not drop the OS/ABI and ABIVersion fields of ELF header

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 2 04:32:17 PST 2019


jhenderson added a comment.

> I'd like @jhenderson to comment if their use case might ever require them to specify what the OSABI and/or ABIVersion might need to be set via a flag for the BinaryELFBuilder case.

@jakehehrlich - At the moment, no we don't have a use case for that. If we ever do, I'll either file a bug or create a review.

@grimar - thanks for the fix!


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55886/new/

https://reviews.llvm.org/D55886





More information about the llvm-commits mailing list