[PATCH] D56194: [gn build] Add fuzzers in llvm/tools that are needed for check-llvm

[Nico Weber via Phabricator via llvm-commits]

thakis marked an inline comment as done.
thakis added inline comments.


================
Comment at: llvm/utils/gn/build/fuzzer.gni:29
+template("fuzzer") {
+  assert(defined(invoker.dummy_main))
+  assert(defined(invoker.sources))
----------------
phosek wrote:
> I checked the LLVM `add_llvm_fuzzer` function and `DUMMY_MAIN` is just an optional argument which is only included in `LLVM_OPTIONAL_SOURCES` for IDE but otherwise ignored if `llvm_use_sanitize_coverage` or `llvm_use_sanitize_coverage` is set. Shouldn't this behave the same?
This template also only uses dummy_main if `llvm_lib_fuzzing_engine` and `llvm_use_sanitize_coverage` both aren't set  (see the two `not_needed`s) -- it tries to do the same. Maybe I got it wrong?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56194/new/

https://reviews.llvm.org/D56194