[PATCH] D56193: [gn build] Add some llvm/tools: lli, lli-child-target

[Nico Weber via Phabricator via llvm-commits]

thakis marked an inline comment as done.
thakis added inline comments.


================
Comment at: llvm/utils/gn/secondary/BUILD.gn:11
+    "//llvm/tools/lli",
+    "//llvm/tools/lli/ChildTarget:lli-child-target",
     "//llvm/tools/llvm-cfi-verify",
----------------
phosek wrote:
> You seem to be overriding the name of the target to match the name of the directory and then setting the `output_name` explicitly everywhere. Is there a reason why not to use the same approach here as well?
I do that for static_libraries but not for executables (other example I can think of: clang/tools/driver:clang). I can change it to use output_name here if you prefer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56193/new/

https://reviews.llvm.org/D56193