[PATCH] D56064: More tolerance for flaky tests in libc++ on NetBSD

Louis Dionne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 1 13:47:49 PST 2019


ldionne added a comment.

I think the tests pointed out by http://lab.llvm.org:8011/builders/lldb-amd64-ninja-netbsd8/builds/17863 are always flaky, not only on FreeBSD. Also, this commit will affect all tests that are marked as flaky, not only the ones that are failing in lldb-amd64-ninja-netbsd8 <http://lab.llvm.org:8011/builders/lldb-amd64-ninja-netbsd8/builds/17863>. Instead, I would suggest either taking the time to fix the flaky tests, or always making the max retry equal to 9 for flaky test. I don't see a reason for tests marked as flaky not to have a higher retry count (speed shouldn't be a problem since it only affects flaky tests).


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56064/new/

https://reviews.llvm.org/D56064





More information about the llvm-commits mailing list