[PATCH] D56161: [AMDGPU] Fix scalar operand folding.

Ron Lieberman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 30 11:25:33 PST 2018


ronlieb added a comment.

generally seems fine to me.
Would it be reasonable/useful to have a lit test that somewhat represents what we observed in the DeviceMemory test ?
if you think the fdiv32-to-rcp-folding.ll adequately covers it, then thats fine by me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56161/new/

https://reviews.llvm.org/D56161





More information about the llvm-commits mailing list