[PATCH] D56148: [PowerPC] Fix machine verify pass error for PATCHPOINT pseudo instruction that bad machine code

[Zhang Kang via Phabricator via llvm-commits]

ZhangKang marked 2 inline comments as done.
ZhangKang added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5098
+  // in EmitInstrWithCustomInserter.
+  if (isSVR4ABI && isPPC64 && !isPatchPoint) 
     Ops.push_back(DAG.getRegister(PPC::X2, PtrVT));
----------------
nemanjai wrote:
> This condition is a never true if the previous one isn't. So this can be changed to just `if (!isPatchPoint)` and contained within the above `if (isSVR4ABI && isPPC64)`.
I have updated the patch to follow your suggestion.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56148/new/

https://reviews.llvm.org/D56148